Page MenuHomeFreeBSD

ctl ramdisk: Free compare buffer after a compare I/O request.
ClosedPublic

Authored by jhb on Feb 18 2022, 5:30 PM.
Tags
None
Referenced Files
F143123574: D34316.id102951.diff
Mon, Jan 26, 6:46 AM
Unknown Object (File)
Sun, Jan 25, 7:06 PM
Unknown Object (File)
Sat, Jan 24, 11:49 PM
Unknown Object (File)
Tue, Jan 6, 10:39 AM
Unknown Object (File)
Dec 8 2025, 3:30 AM
Unknown Object (File)
Nov 27 2025, 3:28 PM
Unknown Object (File)
Nov 17 2025, 3:55 AM
Unknown Object (File)
Nov 15 2025, 9:23 PM
Subscribers

Details

Summary

For a compare request, the ramdisk backend allocates a temporary
buffer to hold the I/O data and then compares it against the LUN's
pages in ctl_backend_ramdisk_cmp after the data has been filled.
However, the tempory buffer was leaked when after the comparison was
complete. Fix this by freeing the buffer after the comparison.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 18 2022, 5:30 PM

I haven't figured out a good way to test this (don't see a way to easily generate COMPARE WRITE or VERIFY commands to daX), just noticed this while investigating a possible memory leak reported by Chelsio's QA folks.

Looks good to me.

There are sg_compare_and_write and sg_verify in sg3_utils port.

This revision is now accepted and ready to land.Feb 18 2022, 5:47 PM

Thanks, I tested with sg_verify and sg_compare_and_write.