Page MenuHomeFreeBSD

ctl ramdisk: Free compare buffer after a compare I/O request.
ClosedPublic

Authored by jhb on Feb 18 2022, 5:30 PM.
Tags
None
Referenced Files
F137952487: D34316.id102951.diff
Thu, Nov 27, 3:28 PM
Unknown Object (File)
Mon, Nov 17, 3:55 AM
Unknown Object (File)
Sat, Nov 15, 9:23 PM
Unknown Object (File)
Sun, Nov 9, 7:26 AM
Unknown Object (File)
Sat, Nov 8, 1:15 AM
Unknown Object (File)
Mon, Nov 3, 2:29 AM
Unknown Object (File)
Thu, Oct 30, 2:34 AM
Unknown Object (File)
Wed, Oct 29, 3:42 PM
Subscribers

Details

Summary

For a compare request, the ramdisk backend allocates a temporary
buffer to hold the I/O data and then compares it against the LUN's
pages in ctl_backend_ramdisk_cmp after the data has been filled.
However, the tempory buffer was leaked when after the comparison was
complete. Fix this by freeing the buffer after the comparison.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 18 2022, 5:30 PM

I haven't figured out a good way to test this (don't see a way to easily generate COMPARE WRITE or VERIFY commands to daX), just noticed this while investigating a possible memory leak reported by Chelsio's QA folks.

Looks good to me.

There are sg_compare_and_write and sg_verify in sg3_utils port.

This revision is now accepted and ready to land.Feb 18 2022, 5:47 PM

Thanks, I tested with sg_verify and sg_compare_and_write.