Page MenuHomeFreeBSD

fix build arm64 with options IOMMU
ClosedPublic

Authored by jsm on Feb 3 2022, 11:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 30, 8:51 AM
Unknown Object (File)
Wed, Nov 27, 2:39 AM
Unknown Object (File)
Thu, Nov 21, 2:10 PM
Unknown Object (File)
Nov 1 2024, 4:32 PM
Unknown Object (File)
Oct 25 2024, 4:19 PM
Unknown Object (File)
Oct 21 2024, 7:47 AM
Unknown Object (File)
Oct 5 2024, 2:19 PM
Unknown Object (File)
Sep 30 2024, 2:24 PM
Subscribers

Details

Summary

after d950c5898a2d UINT64_C and bzero is no longer defined in sys/arm64/iommu/iommu_pmap.c readd sys/systm.h

Test Plan

Builds with stock generic config with "options IOMMU" added

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jsm requested review of this revision.Feb 3 2022, 11:15 AM
jsm edited the summary of this revision. (Show Details)
jsm edited the test plan for this revision. (Show Details)

bzero is needed as well, so include full systm.h

sys/arm64/iommu/iommu_pmap.c
47

While there, sys/mutex.h and sys/rwlock.h require sys/lock.h. Put it before mutex.

52

sys/systm.h should go right after sys/param.h

There is probably no LINT config with this option, which is why I did not noticed the problem while doing tinderbox for sys/kassert.h. IMO it is worth adding it to arm64 LINT, or whatever the place is.

jsm marked an inline comment as done.Feb 3 2022, 3:27 PM
jsm marked an inline comment as done.

Will you add the option to LINT?

This revision is now accepted and ready to land.Feb 3 2022, 3:37 PM
This revision was automatically updated to reflect the committed changes.