fix build arm64 with options IOMMU
ClosedPublic
Actions

Authored by jsm on Feb 3 2022, 11:15 AM.

Details

Reviewers

kib
manu

Commits

rGea07ba11700f: sys/arm64/iommu/iommu_pmap.c readd sys/systm.h

Summary

after d950c5898a2d UINT64_C and bzero is no longer defined in sys/arm64/iommu/iommu_pmap.c readd sys/systm.h

Test Plan

Builds with stock generic config with "options IOMMU" added

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jsm created this revision.Feb 3 2022, 11:15 AM

Herald added a reviewer: manu. · View Herald TranscriptFeb 3 2022, 11:15 AM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

jsm requested review of this revision.Feb 3 2022, 11:15 AM

bzero is needed as well, so include full systm.h

kib added inline comments.Feb 3 2022, 12:37 PM

sys/arm64/iommu/iommu_pmap.c
47	While there, sys/mutex.h and sys/rwlock.h require sys/lock.h. Put it before mutex.
52	sys/systm.h should go right after sys/param.h

There is probably no LINT config with this option, which is why I did not noticed the problem while doing tinderbox for sys/kassert.h. IMO it is worth adding it to arm64 LINT, or whatever the place is.

reorder includes

jsm marked an inline comment as done.Feb 3 2022, 3:27 PM

jsm marked an inline comment as done.

Will you add the option to LINT?

This revision is now accepted and ready to land.Feb 3 2022, 3:37 PM

Closed by commit rGea07ba11700f: sys/arm64/iommu/iommu_pmap.c readd sys/systm.h (authored by jsm). · Explain WhyFeb 3 2022, 7:06 PM

This revision was automatically updated to reflect the committed changes.

jsm added a commit: rGea07ba11700f: sys/arm64/iommu/iommu_pmap.c readd sys/systm.h.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

iommu/

iommu_pmap.c

2 lines

Diff 102338

View Options

sys/arm64/iommu/iommu_pmap.c

fix build arm64 with options IOMMUClosedPublicActions