Page MenuHomeFreeBSD

iwlwifi: Disable -Wformat when building with GCC.
ClosedPublic

Authored by jhb on Feb 2 2022, 8:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 24, 11:51 PM
Unknown Object (File)
Jul 1 2024, 3:50 AM
Unknown Object (File)
Jun 23 2024, 7:37 AM
Unknown Object (File)
Jun 23 2024, 7:25 AM
Unknown Object (File)
Jun 17 2024, 11:14 AM
Unknown Object (File)
May 24 2024, 8:52 AM
Unknown Object (File)
Feb 20 2024, 10:39 PM
Unknown Object (File)
Feb 16 2024, 6:12 AM
Subscribers

Details

Summary

GCC's -Wformat complains about NULL format strings passed to
iwl_fw_dbg_collect_trig (though the function handles NULL format
strings). Curious that upstream iwlwifi in Linux is built with GCC
and explicitly opts into this warning via the __printf() attribute.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 2 2022, 8:21 PM

Yeah, on the other hand they seem to have trouble adding extra options to just the driver -- from my reading between lines; who knows...

This revision is now accepted and ready to land.Feb 2 2022, 9:44 PM