Page MenuHomeFreeBSD

iwlwifi: Disable -Wformat when building with GCC.
ClosedPublic

Authored by jhb on Feb 2 2022, 8:21 PM.
Tags
None
Referenced Files
F132233788: D34146.id102336.diff
Wed, Oct 15, 1:18 AM
F132233777: D34146.id102274.diff
Wed, Oct 15, 1:18 AM
F132233770: D34146.id.diff
Wed, Oct 15, 1:18 AM
Unknown Object (File)
Tue, Oct 14, 4:31 PM
Unknown Object (File)
Wed, Sep 24, 2:57 AM
Unknown Object (File)
Tue, Sep 23, 6:55 AM
Unknown Object (File)
Tue, Sep 23, 1:04 AM
Unknown Object (File)
Aug 6 2025, 12:37 AM
Subscribers

Details

Summary

GCC's -Wformat complains about NULL format strings passed to
iwl_fw_dbg_collect_trig (though the function handles NULL format
strings). Curious that upstream iwlwifi in Linux is built with GCC
and explicitly opts into this warning via the __printf() attribute.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 2 2022, 8:21 PM

Yeah, on the other hand they seem to have trouble adding extra options to just the driver -- from my reading between lines; who knows...

This revision is now accepted and ready to land.Feb 2 2022, 9:44 PM