hardening: replace dialog with bsddialog (and fix --separate-output).
ClosedPublic
Actions

Authored by asiciliano on Jan 30 2022, 6:49 PM.

Details

Reviewers

bapt
robak
emaste

Commits

rG4d1ba6febfa7: bsdinstall hardening: Replace dialog with bsddialog

Summary

Replace dialog with bsddialog in bsdinstall/scripts/hardening, fix bsddialog --separate-output,
add a "retval check" to avoid to do anything with ESC key and bsddialog error.

Test Plan

Menu, radiolist, checklist and mixedlist are the most tested features of bsddialog (tzsetup, kbdmap, portconfig).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asiciliano created this revision.Jan 30 2022, 6:49 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 30 2022, 6:49 PM

asiciliano requested review of this revision.Jan 30 2022, 6:49 PM

asiciliano edited the test plan for this revision. (Show Details)

asiciliano edited the test plan for this revision. (Show Details)Jan 30 2022, 7:00 PM

asiciliano added reviewers: bapt, robak, emaste.Jan 30 2022, 7:59 PM

asiciliano added a parent revision: D34101: Build bsddialog utility.Jan 30 2022, 9:07 PM

bapt accepted this revision.Mar 4 2022, 7:14 PM

This revision is now accepted and ready to land.Mar 4 2022, 7:14 PM

Closed by commit rG4d1ba6febfa7: bsdinstall hardening: Replace dialog with bsddialog (authored by asiciliano). · Explain WhyMar 22 2022, 11:59 PM

This revision was automatically updated to reflect the committed changes.

asiciliano added a commit: rG4d1ba6febfa7: bsdinstall hardening: Replace dialog with bsddialog.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsdinstall/

scripts/

hardening

10 lines

Diff 104104

View Options

usr.sbin/bsdinstall/scripts/hardening

bsdinstall/scripts/hardening: replace dialog with bsddialog (and fix --separate-output).ClosedPublicActions