Page MenuHomeFreeBSD

cp: fix some cases with infinite recursion

Authored by kevans on Jan 19 2022, 5:06 AM.
Referenced Files
Unknown Object (File)
Sat, Sep 30, 9:15 AM
Unknown Object (File)
Sun, Sep 10, 12:39 PM
Unknown Object (File)
Wed, Sep 6, 8:13 AM
Unknown Object (File)
Aug 14 2023, 11:09 PM
Unknown Object (File)
Aug 14 2023, 12:27 PM
Unknown Object (File)
Aug 12 2023, 8:27 PM
Unknown Object (File)
Jul 4 2023, 9:35 AM
Unknown Object (File)
Jun 19 2023, 8:31 PM



As noted in the PR, cp -R has some surprising behavior. Typically, when
you cp -R foo bar where both foo and bar exist, foo is cleanly copied
to foo/bar. When you cp -R foo foo (where foo clearly exists), cp(1)
goes a little off the rails as it creates foo/foo, then discovers that
and creates foo/foo/foo, so on and so forth, until it eventually fails.

POSIX doesn't seem to disallow this behavior, but it isn't very useful.
GNU cp(1) will detect the recursion and squash it, but emit a message in
the process that it has done so.

This change seemingly follows the GNU behavior, but it currently doesn't
warn about the situation -- the author feels that the final product is
about what one might expect from doing this and thus, doesn't need a
warning. The author doesn't feel strongly about this.

PR: 235438

Diff Detail

rG FreeBSD src repository
Lint Not Applicable
Tests Not Applicable