Page MenuHomeFreeBSD

fix "set but not used" in the tws driver
ClosedPublic

Authored by rew on Jan 7 2022, 7:34 PM.

Details

Summary

With __diagused, these warnings were still emitted since INVARIANTS is
defined but TWS_DEBUG is not.

Not sure if it's better to go with __tws_debug or something like:

#ifdef TWS_DEBUG
        u_int32_t reg;
#endif

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rew requested review of this revision.Jan 7 2022, 7:34 PM

__tws_debug is a little shorter, but it's also a bit odd... Since you already have the right place to drop it into tws_services.h, thats likely pushes things in favor of that instead of #ifdef TWS_DEBUG or similar.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2022, 11:32 PM
This revision was automatically updated to reflect the committed changes.