Differential D33757

cryptosoft: Use multi-block encrypt/decrypt for AES-CCM.
ClosedPublic
Actions

Authored by jhb on Jan 5 2022, 10:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 8, 7:43 PM

	Unknown Object (File)
	Wed, Nov 5, 9:17 PM

	Unknown Object (File)
	Sun, Nov 2, 3:55 PM

	Unknown Object (File)
	Fri, Oct 31, 2:53 AM

	Unknown Object (File)
	Wed, Oct 29, 1:57 PM

	Unknown Object (File)
	Wed, Oct 29, 12:56 PM

	Unknown Object (File)
	Wed, Oct 29, 12:56 PM

	Unknown Object (File)
	Tue, Oct 28, 4:24 AM

Subscribers

Details

Reviewers

Commits

rGf8580fcaa1e1: cryptosoft: Use multi-block encrypt/decrypt for AES-CCM.

Summary

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 5 2022, 10:14 PM

Herald added subscribers: jmg, imp. · View Herald TranscriptJan 5 2022, 10:14 PM

jhb requested review of this revision.Jan 5 2022, 10:14 PM

Harbormaster completed remote builds in B43726: Diff 101018.Jan 5 2022, 10:14 PM

jhb added a parent revision: D33756: cryptosoft: Use multi-block encrypt/decrypt for AES-GCM..Jan 5 2022, 10:14 PM

jhb added a child revision: D33758: cryptosoft: Use multi-block encrypt/decrypt for ChaCha20-Poly1305..

I think most of my comments in D33756 apply here too.

sys/opencrypto/cryptosoft.c
861–871	Is this the main difference with swcr_gcm()? I wonder if it'd be worth trying to share code between them. Maybe not, I guess the main goal here is to provide a convenient way to test the encrypt_multi implementations.

This revision is now accepted and ready to land.Jan 6 2022, 3:16 PM

Use for loop instead of while.
Handle boundary conditions when segment ends on a block boundary.

This revision now requires review to proceed.Jan 6 2022, 9:55 PM

Harbormaster completed remote builds in B43746: Diff 101064.Jan 6 2022, 9:55 PM

markj accepted this revision.Jan 7 2022, 2:18 PM

This revision is now accepted and ready to land.Jan 7 2022, 2:18 PM

Closed by commit rGf8580fcaa1e1: cryptosoft: Use multi-block encrypt/decrypt for AES-CCM. (authored by jhb). · Explain WhyJan 11 2022, 10:39 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGf8580fcaa1e1: cryptosoft: Use multi-block encrypt/decrypt for AES-CCM..

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

104 lines

Diff 101331

sys/opencrypto/cryptosoft.c

Loading...