bsd.endian.mk: Sort architecture list
ClosedPublic
Actions

Authored by imp on Jan 4 2022, 7:52 PM.

Details

Reviewers

emaste
jrtc27

Commits

rGd373e61ef302: bsd.endian.mk: Sort architecture list

Summary

Sort arm alphabetically.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43705
Build 40593: arc lint + arc unit

Event Timeline

imp created this revision.Jan 4 2022, 7:52 PM

Herald added subscribers: emaste, bdrewery. · View Herald TranscriptJan 4 2022, 7:52 PM

imp requested review of this revision.Jan 4 2022, 7:52 PM

Harbormaster completed remote builds in B43705: Diff 100938.Jan 4 2022, 7:52 PM

sure

This revision is now accepted and ready to land.Jan 4 2022, 7:55 PM

imp added a reviewer: jrtc27.Jan 4 2022, 7:57 PM

jrtc27 added inline comments.Jan 4 2022, 8:05 PM

share/mk/bsd.endian.mk
5	m < r

emaste added inline comments.Jan 4 2022, 8:07 PM

share/mk/bsd.endian.mk
5	indeed

oh, nothing

This revision now requires review to proceed.Jan 4 2022, 8:51 PM

Harbormaster completed remote builds in B43708: Diff 100941.Jan 4 2022, 8:51 PM

I don't see a change to the diff?

git arc update main.. updated this, even though there was no change. I'll just land it so that doesn't happen again.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 4 2022, 8:58 PM

Closed by commit rGd373e61ef302: bsd.endian.mk: Sort architecture list (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGd373e61ef302: bsd.endian.mk: Sort architecture list.

Ok, but, the commit message doesn't match the diff; I'd expect one of the two to be changed

Revision Contents
Changeset List

Path

Size

share/

mk/

bsd.endian.mk

2 lines

Diff 100938

View Options

share/mk/bsd.endian.mk

	# $FreeBSD$			# $FreeBSD$

	.if ${MACHINE_CPUARCH} == "aarch64" \|\| \			.if ${MACHINE_CPUARCH} == "aarch64" \|\| \
				${MACHINE_CPUARCH} == "arm" \|\| \
	${MACHINE_ARCH} == "amd64" \|\| \			${MACHINE_ARCH} == "amd64" \|\| \
				jrtc27Unsubmitted Not Done Inline Actions m < r jrtc27: m < r
				emasteUnsubmitted Not Done Inline Actions indeed emaste: indeed
	${MACHINE_ARCH} == "i386" \|\| \			${MACHINE_ARCH} == "i386" \|\| \
	${MACHINE_CPUARCH} == "arm" \|\| \
	${MACHINE_ARCH} == "powerpc64le" \|\| \			${MACHINE_ARCH} == "powerpc64le" \|\| \
	${MACHINE_CPUARCH} == "riscv"			${MACHINE_CPUARCH} == "riscv"
	TARGET_ENDIANNESS= 1234			TARGET_ENDIANNESS= 1234
	CAP_MKDB_ENDIAN= -l			CAP_MKDB_ENDIAN= -l
	LOCALEDEF_ENDIAN= -l			LOCALEDEF_ENDIAN= -l
	.elif ${MACHINE_ARCH} == "powerpc" \|\| \			.elif ${MACHINE_ARCH} == "powerpc" \|\| \
	${MACHINE_ARCH} == "powerpc64" \|\| \			${MACHINE_ARCH} == "powerpc64" \|\| \
	${MACHINE_ARCH} == "powerpcspe"			${MACHINE_ARCH} == "powerpcspe"
	Show All 19 Lines

bsd.endian.mk: Sort architecture listClosedPublicActions