Differential D33717

route: remove write-only struct hostent from getaddr()
ClosedPublic
Actions

Authored by emaste on Jan 2 2022, 12:18 AM.

Tags

None

Referenced Files

	F166328690: D33717.diff
	Wed, Aug 12, 10:55 PM

	F166305365: D33717.vs100814.id100815.diff
	Wed, Aug 12, 7:12 PM

	Unknown Object (File)
	Wed, Aug 12, 11:56 AM

	Unknown Object (File)
	Sat, Aug 8, 4:03 PM

	Unknown Object (File)
	Wed, Aug 5, 8:53 AM

	Unknown Object (File)
	Wed, Aug 5, 3:18 AM

	Unknown Object (File)
	Wed, Aug 5, 2:19 AM

	Unknown Object (File)
	Tue, Aug 4, 6:33 AM

Subscribers

Details

Reviewers

melifaro
imp
hrs

Commits

rGe5bcc6a85677: route: remove write-only struct hostent from getaddr()
rGf567fcb2ffc4: route: remove write-only struct hostent from getaddr()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jan 2 2022, 12:18 AM

emaste created this revision.

emaste updated this revision to Diff 100815.Jan 2 2022, 12:20 AM

emaste added reviewers: melifaro, imp, hrs.

emaste added a subscriber: freebsd-net-list.

emaste mentioned this in D33710: route: silence Clang set but not used warning under WITHOUT_INET.Jan 2 2022, 1:33 AM

emaste removed reviewers: imp, hrs.

emaste added reviewers: imp, hrs.

remove now-unused variable

As @melifaro pointed out to prompt this change hp was passed to three getaddr() calls in newroute(), and was not otherwise used, and getaddr() does not use the passed-in value.

emaste added a subscriber: brooks.Jan 5 2022, 3:00 PM

emaste removed a subscriber: freebsd-net-list.Jan 5 2022, 3:07 PM

melifaro accepted this revision.Jan 5 2022, 5:03 PM

This revision is now accepted and ready to land.Jan 5 2022, 5:03 PM

Closed by commit rGf567fcb2ffc4: route: remove write-only struct hostent from getaddr() (authored by emaste). · Explain WhyJan 6 2022, 3:51 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGf567fcb2ffc4: route: remove write-only struct hostent from getaddr().

emaste added a commit: rGe5bcc6a85677: route: remove write-only struct hostent from getaddr().Jan 27 2022, 12:37 AM

Revision Contents
Changeset List

Path

Size

sbin/

route/

33 lines

Diff 101055

sbin/route/route.c

Loading...