The amd64 and amd64_ia32 vdso scripts are almost identical. To simplify
adding new architectures merge these into a new file and replace the
originals with just the configuration needed by the common script.
Details
Details
- Reviewers
kib
Builds, but untested
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 43638 Build 40526: arc lint + arc unit
Event Timeline
Comment Actions
I did understand that the files are very similar, but I wanted to have a freedom of doing modifications for one case without breaking other. The scripts are very short so that the duplication is not too severe, and duplication allow maintainers of arches to work without stepping on each others toes.
But I do not object strongly. If this makes arm64 easier to come with vdso, lets merge the scripts.
| sys/tools/amd64_ia32_vdso.sh | ||
|---|---|---|
| 36 | Wouldn't CFLAGS conflict with Makefile-level var, or confuse reader about the source of it? I would prefer some other name for this quirk. | |
| sys/tools/vdso.sh | ||
| 51 | Probably size should be parametrized as well | |