loader.efi: to preserve heap space, use AllocatePages() for shadow_fb
ClosedPublic
Actions

Authored by tsoome on Dec 21 2021, 12:13 PM.

Details

Reviewers

Group Reviewers

Commits

rG835f59f32444: loader.efi: to preserve heap space, use AllocatePages() for shadow_fb
rG221376db0cb7: loader.efi: to preserve heap space, use AllocatePages() for shadow_fb

Summary

shadow FB size could be rather large and depends on resolution,
instead of using heap, allocate dedicated space outside of heap.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Dec 21 2021, 12:13 PM

Herald added a reviewer: manu. · View Herald TranscriptDec 21 2021, 12:13 PM

Herald added subscribers: dab, bcran, imp. · View Herald Transcript

tsoome requested review of this revision.Dec 21 2021, 12:13 PM

Harbormaster completed remote builds in B43525: Diff 100413.Dec 21 2021, 12:13 PM

tsoome added a reviewer: Loader.Dec 21 2021, 12:14 PM

tsoome mentioned this in D33598: loader: efi: Bump the heap from 64 to 128MB..

Works for me and I prefer that, thanks.

This revision is now accepted and ready to land.Dec 21 2021, 2:34 PM

Closed by commit rG221376db0cb7: loader.efi: to preserve heap space, use AllocatePages() for shadow_fb (authored by tsoome). · Explain WhyDec 22 2021, 11:56 AM

This revision was automatically updated to reflect the committed changes.

tsoome added a commit: rG221376db0cb7: loader.efi: to preserve heap space, use AllocatePages() for shadow_fb.

tsoome added a commit: rG835f59f32444: loader.efi: to preserve heap space, use AllocatePages() for shadow_fb.Jan 10 2022, 12:28 PM

Revision Contents
Changeset List

Path

Size

stand/

common/

gfx_fb.h

1 line

efi/

loader/

framebuffer.c

13 lines

Diff 100459

View Options

stand/common/gfx_fb.h