More style(9) fixes.
ClosedPublic
Actions

Authored by araujo on Aug 10 2015, 6:02 AM.

Details

Reviewers

• rodrigc
bapt
ed

Commits

rS286609: More style(9) fixes. No functional changes.

Summary

ed@ and bde@ pointed out some format issues after I synced the
code with the OpenBSD version. Those are cosmetic changes and
besides the style(9), doesn't change the functionalities.

I sent an email to src-committers where I copy'ed bde@ and ed@
with this patch.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

araujo updated this revision to Diff 7810.Aug 10 2015, 6:02 AM

araujo retitled this revision from to More style(9) fixes..

araujo updated this object.

araujo edited the test plan for this revision. (Show Details)

araujo added reviewers: bapt, • rodrigc.

Herald added a subscriber: imp. · View Herald TranscriptAug 10 2015, 6:02 AM

araujo added a reviewer: ed.Aug 10 2015, 6:03 AM

Hi Marcelo,

This change looks good to me, though there are some small additional things that could be improved. Be sure to process those and commit this. Thanks for working on this!

usr.bin/ypmatch/ypmatch.c
87 ↗	(On Diff #7810)	style(9) also discourages the use of `sizeof n`. `sizeof(n)` should be used instead. We also have the `nitems()` macro in `sys/param.h`. Could you change this to the following? for (i = 0; i < nitems(ypaliases); i++)
105 ↗	(On Diff #7810)	This should be written as follows: if (argc - optind < 2)
113 ↗	(On Diff #7810)	Idem.