Page MenuHomeFreeBSD
Differential D33390

amd64: correct size of the SSE area in the xsave layout
ClosedPublic
Actions

Authored by kib on Dec 12 2021, 2:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 11:18 AM
Unknown Object (File)
Wed, Nov 26, 3:06 PM
Unknown Object (File)
Tue, Nov 25, 11:09 AM
Unknown Object (File)
Sat, Nov 22, 5:17 PM
Unknown Object (File)
Wed, Nov 19, 7:02 AM
Unknown Object (File)
Wed, Nov 12, 1:58 AM
Unknown Object (File)
Fri, Nov 7, 5:57 PM
Unknown Object (File)
Oct 21 2025, 3:05 PM
View All 78 Files
Subscribers
imp
mpratt_google.com

Details

Reviewers
markj
jhb
emaste
Commits
rG73b357be9238: amd64: correct size of the SSE area in the xsave layout
Summary

PR: https://github.com/golang/go/issues/46272

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Dec 12 2021, 2:52 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 12 2021, 2:52 AM
kib requested review of this revision.Dec 12 2021, 2:52 AM
emaste accepted this revision.Dec 12 2021, 6:18 PM
emaste added inline comments.
sys/amd64/amd64/fpu.c
487

Indeed, 16 128-bit XMM registers occupy 256 bytes.

I wonder if xsave_area_desc[1].size = 256 would be more clear here.

This revision is now accepted and ready to land.Dec 12 2021, 6:18 PM
emaste added a commit: rG73b357be9238: amd64: correct size of the SSE area in the xsave layout.Dec 12 2021, 11:25 PM
mpratt_google.com added a subscriber: mpratt_google.com.Dec 13 2021, 8:21 PM
mpratt_google.com added inline comments.
sys/amd64/amd64/fpu.c
487

Alternatively/additionally, a reference to the documentation source for these values would be helpful. e.g., Intel SDM Vol 1, Ch. 13.4.1 "Legacy Region of an XSAVE Area", Table 13-1 "Format of the Legacy Region of an XSAVE Area" shows these sizes and offsets.

emaste closed this revision.Fri, Nov 14, 4:48 PM
emaste added inline comments.
sys/amd64/amd64/fpu.c
487

Thanks, a comment like that is in the tree now.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
2 lines

Diff 99861

View Options

sys/amd64/amd64/fpu.c

Loading...