Page MenuHomeFreeBSD

Add kernel support for minidumps on arm64
ClosedPublic

Authored by andrew on Aug 6 2015, 3:18 PM.

Details

Reviewers
None
Group Reviewers
arm64
Commits
rS286958: Add the kernel support for minidumps on arm64.
Summary

This follows the amd64 process of finding what memry to dump py looking at
the kernel page tables. It also adds the standard data to the dump.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

andrew updated this revision to Diff 7715.Aug 6 2015, 3:18 PM
andrew retitled this revision from to Add kernel support for minidumps on arm64.
andrew updated this object.
andrew edited the test plan for this revision. (Show Details)
andrew added reviewers: arm64, peter.
emaste added inline comments.Aug 6 2015, 3:44 PM
sys/arm64/arm64/minidump_machdep.c
19–28 ↗(On Diff #7715)

We should probably keep the "author and contributors" version of the license.

jhb added a subscriber: jhb.Aug 6 2015, 5:36 PM

You have a #if 0'd dump_add_page() in get_pv_entry() in pmap.c you probably want to enable (see also the dump_drop_page() in free_pv_chunk().

See also the uma_small routines in uma_machdep.c. amd64 has to add them explicitly since they use direct map addresses and thus aren't found by the KVA loop. The symptoms would be that the dump wouldn't contain small objects (ones that use a slab size of a page).

peter removed a reviewer: peter.Aug 15 2015, 10:09 PM
emaste added inline comments.Aug 15 2015, 11:51 PM
sys/arm64/arm64/minidump_machdep.c
19–28 ↗(On Diff #7715)

peter@ confirmed he's ok with switching to the up-to-date license

This revision was automatically updated to reflect the committed changes.