Page MenuHomeFreeBSD

git-arc: with "create" allow to specify parent of the first commit
Needs ReviewPublic

Authored by glebius on Wed, Nov 17, 6:28 AM.

Details

Reviewers
markj
imp
Group Reviewers
manpages

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 42863
Build 39751: arc lint + arc unit

Event Timeline

Adding explanations of reviewer* and subscriber* may help as well for people not familiar with the phabricator workflow, but that's plausibly out of scope for this.

tools/tools/git/git-arc.1
38

Unlike reviewer* and subscriber*, I have no idea what parent is for or why/when/how to use it. Since not all contributors will be able to read the actual wrapper well enough to figure it, it needs elaboration.

The change itself looks good, thanks.

tools/tools/git/git-arc.1
38

Indeed, I'd write "parent revision" at least. And a sentence or two of exposition would be good as well.

This revision is now accepted and ready to land.Wed, Nov 17, 2:31 PM
debdrup added inline comments.
tools/tools/git/git-arc.1
38

Unlike reviewer* and subscriber*, I have no idea what parent is for or why/when/how to use it. Since not all contributors will be able to read the actual wrapper well enough to figure it, it needs elaboration.

The syntax should at the very least show if it's only possible to have one parent, or if there can be more - the mdoc can optionally be copied almost verbatum from the above examples if that's the case, or I can assist with creating markup for if there's only one parent, if requested.

Change looks good, modulo the other comments. Tagged a spot that would be the logical place to explain in a setence what reviewer, subscriber and parent revision(s) are.

tools/tools/git/git-arc.1
140

I'd add a .Pp here and explain about parent here. It wouldn't hurt to explain about subscriber and reviewer too, since those are also not explained.

tools/tools/git/git-arc.1
38

There can be only one parent specified. What would be proper mandoc for that? Thanks

This revision now requires review to proceed.Wed, Nov 17, 9:40 PM

Minor grammar nit, but it looks good to me overall with that addition.

tools/tools/git/git-arc.1
81–82

Address pauamma_gundo.com comment