Differential D33000
net-p2p/lidarr: Switch to mono 6.8 Authored by driesm on Nov 15 2021, 8:54 PM. Tags None Referenced Files
Subscribers
Details
Commit message: net-p2p/lidarr: Switch to mono 6.8 Use the most recent mono available with less bugs. While here reformat Makefile with portfmt. PR: 259250 Approved by: michiel@vanbaak.eu (maintainer), tbd (mentor) Differential Revision: https://reviews.freebsd.org/D33000 Testport looks good
Diff Detail
Event TimelineComment Actions In terms of maintainer approval, is it typically the e-mail address or the full or first name that is used in the "Approved by"? Comment Actions I'd say it's typically only the email address for maintainers (in other words, the value of MAINTAINER). However, I tend to use "Name Surname <name.surname@example.org>" for fields like "Reviewed by". Suggestions 1: if the "Approved by" line becomes too long, just have multiple "Approved by" lines instead. Suggestion 2: I've not looked into the PR, but if there is a reason for switching to mono6.8 from the default one, it'd be nice to include that reason in the commit message. Suggestion 3: you may want to run portfmt to get those RUN_DEPENDS lines sorted alphabetically. portfmt and portclippy are my fav tools for cleaning up Makefiles (both are parts of the same portfmt package). Comment Actions Hmm, if the maintainer says it helps the port to use a newer version of mono because of it having less bugs it's probably the way to go... But this change seems quite invasive as it is rarely the case that USES=xxx gets replaced with RUN_DEPENDS. It feels like that whatever issue is the problem here, it should be fixed in mono.mk. Let's commit it though as I've seen other examples of RUN_DEPENDS=mono6.8 in the tree. Comment Actions Agreed. I had taken a look at mono.mk to add a version specifier. |