Page MenuHomeFreeBSD

net-p2p/lidarr: Switch to mono 6.8
ClosedPublic

Authored by driesm on Nov 15 2021, 8:54 PM.

Details

Summary

Commit message:

net-p2p/lidarr: Switch to mono 6.8

Use the most recent mono available with less bugs.
While here reformat Makefile with portfmt.

 PR:			259250
 Approved by:		michiel@vanbaak.eu (maintainer), tbd (mentor)
 Differential Revision:	https://reviews.freebsd.org/D33000
Test Plan

Testport looks good

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

In terms of maintainer approval, is it typically the e-mail address or the full or first name that is used in the "Approved by"?

driesm added reviewers: philip, 0mp.

In terms of maintainer approval, is it typically the e-mail address or the full or first name that is used in the "Approved by"?

I'd say it's typically only the email address for maintainers (in other words, the value of MAINTAINER). However, I tend to use "Name Surname <name.surname@example.org>" for fields like "Reviewed by".

Suggestions 1: if the "Approved by" line becomes too long, just have multiple "Approved by" lines instead.

Suggestion 2: I've not looked into the PR, but if there is a reason for switching to mono6.8 from the default one, it'd be nice to include that reason in the commit message.

Suggestion 3: you may want to run portfmt to get those RUN_DEPENDS lines sorted alphabetically. portfmt and portclippy are my fav tools for cleaning up Makefiles (both are parts of the same portfmt package).

This revision is now accepted and ready to land.Nov 15 2021, 10:25 PM
This revision now requires review to proceed.Nov 16 2021, 5:56 PM

Hmm, if the maintainer says it helps the port to use a newer version of mono because of it having less bugs it's probably the way to go...

But this change seems quite invasive as it is rarely the case that USES=xxx gets replaced with RUN_DEPENDS. It feels like that whatever issue is the problem here, it should be fixed in mono.mk. Let's commit it though as I've seen other examples of RUN_DEPENDS=mono6.8 in the tree.

This revision is now accepted and ready to land.Nov 16 2021, 8:01 PM

Agreed. I had taken a look at mono.mk to add a version specifier.
Maybe something for over the holidays as it doesn't seem that hard to implement.

This revision was automatically updated to reflect the committed changes.