Page MenuHomeFreeBSD

net: sprinkle __predict_false in ip_input on error conditions
ClosedPublic

Authored by mjg on Nov 10 2021, 5:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 7:59 PM
Unknown Object (File)
Jan 16 2024, 5:02 AM
Unknown Object (File)
Dec 27 2023, 2:13 AM
Unknown Object (File)
Dec 20 2023, 5:25 AM
Unknown Object (File)
Nov 5 2023, 8:05 PM
Unknown Object (File)
Nov 5 2023, 12:55 AM
Unknown Object (File)
Oct 8 2023, 2:09 AM
Unknown Object (File)
Oct 4 2023, 7:00 PM

Details

Summary

While here rearrange the RVSP check to inspect proto first and avoid
evaluating V_rsvp in the common case to begin with (most notably avoid
the expensive read).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg requested review of this revision.Nov 10 2021, 5:22 PM
mjg edited the summary of this revision. (Show Details)
glebius added a subscriber: glebius.

One comment not related to the code. As you request reviews from network, maybe add yourself to network, too? Right now there are other patches to ip_input in the network review queue :)

This revision is now accepted and ready to land.Nov 10 2021, 6:07 PM