tests: do not build ktls_test if WITHOUT_OPENSSL

[emaste]

Summary

ktls_test requires openssl to build, and fails if it is not available.
I used MK_OPENSSL in the condition because the test still has some value
even if the system is built without KTLS (i.e., it can be used to verify
that the KTLS build option works correctly).

[emaste]

CI build running here: https://cirrus-ci.com/build/5731779848962048

[jhb]

tests/sys/kern/Makefile

17

It actually uses libcrypto, not libssl, so I wonder if this should be MK_CRYPTO instead? Ah, we don't have a MK_CRYPTO, just a MK_CRYPT which turns off various things.

[jhb]

Note that this test does not depend on WITH_OPENSSL_KTLS. It doesn't use that part of OpenSSL, it only uses crypto code from libcrypto. So you might want to adjust your commit log a bit?

[emaste]

Note that this test does not depend on WITH_OPENSSL_KTLS. It doesn't use that part of OpenSSL, it only uses crypto code from libcrypto.

Yeah. In the commit message I wanted to convey that the "natural" knob would be MK_OPENSSL_KTLS, but there's some value in building it with or without KTLS support, as long as the prerequisites are available.

So maybe just:

ktls_test requires libcrypto to build, and fails if it is not available (which is the case when building WITHOUT_OPENSSL).

[jhb]

Yes. It was the last sentence about the KTLS build option that I think was confusing as it doesn't really test if the KTLS build option works (e.g. the tests don't fail if you build WITHOUT_OPENSSL_KTLS=yes).

[brnrd]

tests/sys/kern/Makefile

17

@emaste Should this not be

.if ${MK_OPENSSL_KTLS} != "no"

?

[brnrd]

Scrap that. Test tests for ktls in the code.