Page MenuHomeFreeBSD
Differential D32884

libkvm: Fix kvm_getloadavg() on modern kernel vmcores
ClosedPublic
Actions

Authored by mgorny_gentoo.org on Nov 7 2021, 9:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 30, 10:34 AM
Unknown Object (File)
Fri, Mar 20, 1:36 AM
Unknown Object (File)
Fri, Mar 20, 1:36 AM
Unknown Object (File)
Fri, Mar 20, 1:36 AM
Unknown Object (File)
Thu, Mar 19, 4:19 PM
Unknown Object (File)
Thu, Mar 19, 4:11 PM
Unknown Object (File)
Thu, Mar 19, 3:57 AM
Unknown Object (File)
Wed, Mar 18, 1:11 PM
View All Files
Subscribers
imp
kib
markj

Details

Reviewers
jhb
emaste
Commits
rG8099a354469a: libkvm: Fix kvm_getloadavg() on modern kernel vmcores
Summary

Fix kvm_getloadavg() to work correctly on vmcores for modern kernel
versions. The kernels no longer include the _fscale symbol causing
the kvm_nlist() invocation to fail. The code seemed to already assume
that _fscale could be missing but the early kvm_nlist() result check
has caused the function to fail if any symbol were missing. Modify
it to only treat _averunnable as obligatory, and handle missing
_fscale gracefully.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mgorny_gentoo.org requested review of this revision.Nov 7 2021, 9:17 PM
mgorny_gentoo.org created this revision.
emaste added subscribers: kib, markj.Nov 8 2021, 2:36 PM
jhb accepted this revision.Nov 9 2021, 5:45 PM
This revision is now accepted and ready to land.Nov 9 2021, 5:45 PM
mgorny_gentoo.org added a comment.Dec 5 2021, 1:13 PM

Could you push this for me, as I don't have push access?

jhb added a comment.Dec 7 2021, 7:40 PM

Do you happen to have an existing git commit for this pushed somewhere public?

mgorny_gentoo.org added a comment.Dec 7 2021, 8:22 PM

I've opened https://github.com/freebsd/freebsd-src/pull/570 for that.

Closed by commit rG8099a354469a: libkvm: Fix kvm_getloadavg() on modern kernel vmcores (authored by mgorny_gentoo.org, committed by jhb). · Explain WhyDec 7 2021, 11:39 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG8099a354469a: libkvm: Fix kvm_getloadavg() on modern kernel vmcores.
Herald added a subscriber: imp. · View Herald TranscriptDec 7 2021, 11:39 PM

Revision Contents
Changeset List

PathSize
lib/
libkvm/
9 lines

Diff 99678

View Options

lib/libkvm/kvm_getloadavg.c

Loading...