Treat internal bridge as subtractive on ThunderX ARM64
ClosedPublic
Actions

Authored by wma_semihalf.com on Aug 3 2015, 9:08 AM.

Details

Reviewers

emaste
jhb
imp

Group Reviewers

arm64

Commits

rS286480: Treat internal bridge as subtractive on ThunderX ARM64

Summary

Internal bridges in Cavium ThunderX SoC
behave as subtractive, but they are unable
to be identified. Force setting an appropriate
flag.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wma_semihalf.com updated this revision to Diff 7604.Aug 3 2015, 9:08 AM

wma_semihalf.com retitled this revision from to Treat internal bridge as subtractive on ThunderX ARM64.

wma_semihalf.com updated this object.

wma_semihalf.com edited the test plan for this revision. (Show Details)

wma_semihalf.com added reviewers: jhb, arm64.

wma_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptAug 3 2015, 9:08 AM

imp added inline comments.Aug 3 2015, 4:06 PM

sys/dev/pci/pci_pci.c
959–969 ↗	(On Diff #7604)	Isn't this the same as the next block of code? It doesn't get set because the ProgIF is wrong? If so, why not just add a note and ID to the following block?

wma_semihalf.com updated this revision to Diff 7635.Aug 4 2015, 5:25 AM

Perfect! Thanks!

This revision is now accepted and ready to land.Aug 4 2015, 3:16 PM

Looks fine to me, although the sort order seems incorrect already prior to this change. Perhaps make the comment "Cavium ThunderX" and then these are sorted alphabetically by mfgr and then part.

Closed by commit rS286480: Treat internal bridge as subtractive on ThunderX ARM64 (authored by zbb). · Explain WhyAug 8 2015, 9:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

pci/

pci_pci.c

5 lines

Diff 7791

View Options

head/sys/dev/pci/pci_pci.c

Treat internal bridge as subtractive on ThunderX ARM64ClosedPublicActions