Allow kern.ipc.maxsockets to be set to current value without error
ClosedPublic
Actions

Authored by allanjude on Nov 1 2021, 1:41 PM.

Details

Reviewers

kevans
markj
rew

Commits

rGc441592a0e15: Allow kern.ipc.maxsockets to be set to current value without error

Summary

Normally setting kern.ipc.maxsockets returns EINVAL if the new value
is not greater than the previous value. This can cause spurious
error messages when sysctl.conf is processed multiple times, or when
automation systems try to ensure the sysctl is set to the correct
value. If the value is unchanged, then just do nothing.

PR: 243532
Sponsored by: Modirum MDPay
Sponsored by: Klara Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

allanjude created this revision.Nov 1 2021, 1:41 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2021, 1:41 PM

allanjude requested review of this revision.Nov 1 2021, 1:41 PM

Harbormaster completed remote builds in B42487: Diff 97803.Nov 1 2021, 1:41 PM

allanjude added reviewers: kevans, markj, rew.Nov 1 2021, 1:42 PM

LGTM, just some nitpicking.

sys/kern/uipc_socket.c
368	I would omit the comment, or explain why it's useful to permit this case. The "what" is already obvious, the "why" a little less so.
370	This can just be `return (0);`. Or move the test into the top-level check: `if (error == 0 && req->newptr != NULL && newmaxsockets != maxsockets)`.