Page MenuHomeFreeBSD

Treat internal bridge as subtractive on ThunderX ARM64
ClosedPublic

Authored by wma_semihalf.com on Aug 3 2015, 9:08 AM.

Details

Summary
Internal bridges in Cavium ThunderX SoC
behave as subtractive, but they are unable
to be identified. Force setting an appropriate
flag.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wma_semihalf.com retitled this revision from to Treat internal bridge as subtractive on ThunderX ARM64.
wma_semihalf.com updated this object.
wma_semihalf.com edited the test plan for this revision. (Show Details)
wma_semihalf.com added reviewers: jhb, arm64.
wma_semihalf.com set the repository for this revision to rS FreeBSD src repository.
imp added inline comments.Aug 3 2015, 4:06 PM
sys/dev/pci/pci_pci.c
959–969 ↗(On Diff #7604)

Isn't this the same as the next block of code? It doesn't get set because the ProgIF is wrong? If so, why not just add a note and ID to the following block?

imp accepted this revision.Aug 4 2015, 3:16 PM
imp added a reviewer: imp.

Perfect! Thanks!

This revision is now accepted and ready to land.Aug 4 2015, 3:16 PM
emaste accepted this revision.Aug 4 2015, 3:21 PM
emaste added a reviewer: emaste.
emaste added a subscriber: emaste.

Looks fine to me, although the sort order seems incorrect already prior to this change. Perhaps make the comment "Cavium ThunderX" and then these are sorted alphabetically by mfgr and then part.

This revision was automatically updated to reflect the committed changes.