Helper routine to call the kernel to get a path to the named device.
Different path enumeration methods (called locators) can be used
for different path types depending on what the kernel implements.
Sponsored by: Netflix
Details
Details
- Reviewers
jhb - Group Reviewers
manpages - Commits
- rGb01f409ffeda: libdevctl: Add devctl_getpath
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/libdevctl/devctl.c | ||
|---|---|---|
| 171 | ||
| 185 | I don't know that you need this check? The ioctl handler in the kernel already validates the length, and it enforces a much smaller limit (64) anyway? | |
| 190 | ||
| 203 | Note that this isn't necessarily guaranteed to loop twice if the path "changes" size for some reason (not sure if we have any paths that will ever change size dynamically?) It might be nice to return a more specific error value for the buffer being too short. Other places in the kernel (e.g. sysctl handlers) tend to return ENOMEM for this rather than EINVAL. (The argument wasn't invalid, just too small). That would let you then just loop on the specific errno value without the BUFLEN check. It might still loop more than once, but you would know it wasn't due to some other EINVAL case at least. | |