Fix cross-building on Linux/aarch64
ClosedPublic
Actions

Authored by kevans on Oct 18 2021, 2:28 AM.

Details

Reviewers

allanjude
emaste
imp
arichardson

Commits

rG8c22b9f3ba58: Fix cross-building on Linux/aarch64

Summary

Add necessary bits to detect ELF format on Linux/aarch64; note that
Linux calls it aarch64 where we would typically call it arm64 (uname -m)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Oct 18 2021, 2:28 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 18 2021, 2:28 AM

kevans requested review of this revision.Oct 18 2021, 2:28 AM

Harbormaster completed remote builds in B42213: Diff 97029.Oct 18 2021, 2:28 AM

kevans added a reviewer: emaste.Oct 18 2021, 2:28 AM

I have other comments on the makefile since it seems to confuse machine and machine_arch in the terminology. But that's beyond the scope of this change...

This revision is now accepted and ready to land.Oct 18 2021, 3:02 AM

A lot of that makefile is a bit confusing since I tried to get things to work without understanding everything... But since this fixed the build LGTM.

arichardson added inline comments.Oct 18 2021, 1:06 PM