Page MenuHomeFreeBSD

mixer(3): add symbol versioning
ClosedPublic

Authored by christos on Oct 1 2021, 10:20 AM.
Referenced Files
F162890598: D32254.id96063.diff
Sat, Jul 18, 1:33 AM
Unknown Object (File)
Wed, Jul 8, 9:10 PM
Unknown Object (File)
Wed, Jul 8, 9:09 PM
Unknown Object (File)
Tue, Jul 7, 5:57 PM
Unknown Object (File)
Sun, Jul 5, 3:33 AM
Unknown Object (File)
Sat, Jul 4, 11:20 AM
Unknown Object (File)
Sat, Jul 4, 9:42 AM
Unknown Object (File)
Fri, Jul 3, 12:23 PM
Subscribers
None

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.
hselasky added inline comments.
lib/libmixer/Symbol.map
23

macros don't belong here.

lib/libmixer/Makefile
9

The MLINKS should probably be an own patch.

christos marked 2 inline comments as done.

Remove macros and MLINKS.

This revision is now accepted and ready to land.Oct 1 2021, 10:28 AM
lib/libmixer/Symbol.map
6

No, we do not do it this way. Please look at other libs with symbol version used, for instance libprocstat which seems to be a good example.

There is a single namespace per release, for 14 it is FBSD_1.7. So put the lib' symbols under this version. Versions are defined in lib/libc/Versions.def, again please take a look at libprocstat/Makefile how to reference it.

Also, formally to keep ABI backward compatible we would need to bump libmixer so version, but I do not see a point to go through this relatively painful procedure for head-only library still under development.

christos marked an inline comment as done.

Fix namespace and referencing.

This revision now requires review to proceed.Oct 1 2021, 10:55 AM
This revision is now accepted and ready to land.Oct 1 2021, 10:58 AM

I also pushed the MLINKS chunks separately.l