Rewrite scan procedure with a FSM.
ClosedPublic
Actions

Authored by delphij on Jul 27 2015, 6:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 14, 4:52 PM

	Unknown Object (File)
	Sat, May 2, 11:08 AM

	Unknown Object (File)
	Tue, Apr 28, 6:09 PM

	Unknown Object (File)
	Tue, Apr 28, 6:04 PM

	Unknown Object (File)
	Tue, Apr 28, 5:18 PM

	Unknown Object (File)
	Mon, Apr 27, 9:42 PM

	Unknown Object (File)
	Thu, Apr 16, 11:10 PM

	Unknown Object (File)
	Thu, Apr 16, 11:07 PM

View All Files

Subscribers

imp

Details

Reviewers

emaste
pfg
bapt

Commits

rS285923: Rewrite scan procedure with a FSM. This improves code readability by

Summary

This proposed changeset rewrites the scan procedure of ident(1) using a
FSM. This improves code readability by making clear transits between
different states, and avoids bug with handling repeated $'s.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij updated this revision to Diff 7392.Jul 27 2015, 6:43 PM

delphij retitled this revision from to Rewrite scan procedure with a FSM..

delphij updated this object.

delphij edited the test plan for this revision. (Show Details)

delphij added reviewers: bapt, emaste, pfg.

Herald added a subscriber: imp. · View Herald TranscriptJul 27 2015, 6:43 PM

bapt accepted this revision.Jul 27 2015, 6:48 PM

bapt edited edge metadata.

This revision is now accepted and ready to land.Jul 27 2015, 6:48 PM

Closed by commit rS285923: Rewrite scan procedure with a FSM. This improves code readability by (authored by delphij). · Explain WhyJul 27 2015, 7:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

ident/

ident.c

189 lines

Diff 7394

View Options

head/usr.bin/ident/ident.c

Rewrite scan procedure with a FSM.ClosedPublicActions