Page MenuHomeFreeBSD

mmc: Fix regression in 8a8166e5bcfb breaking Stratix 10 boot

Authored by jrtc27 on Sep 28 2021, 6:19 PM.
Referenced Files
Unknown Object (File)
Wed, Nov 8, 4:47 AM
Unknown Object (File)
Oct 3 2023, 9:43 PM
Unknown Object (File)
Sep 16 2023, 4:58 PM
Unknown Object (File)
Sep 10 2023, 1:01 AM
Unknown Object (File)
Aug 16 2023, 7:54 AM
Unknown Object (File)
Aug 11 2023, 1:23 AM
Unknown Object (File)
Aug 11 2023, 1:16 AM
Unknown Object (File)
Aug 8 2023, 6:55 PM



The refactoring in 8a8166e5bcfb introduced a functional change that
breaks booting on the Stratix 10, hanging when it should be attaching
da0. Previously OF_getencprop was called with a pointer to host->f_max,
so if it wasn't present then the existing value was left untouched, but
after that commit it will instead clobber the value with 0. The dwmmc
driver, as used on the Stratix 10, sets a default value before calling
mmc_fdt_parse and so was broken by this functional change. It appears
that aw_mmc also does the same thing, so was presumably also broken on
some boards.

Fixes: 8a8166e5bcfb ("mmc: switch mmc_helper to device_ api")

Diff Detail

rG FreeBSD src repository
Lint Not Applicable
Tests Not Applicable