Page MenuHomeFreeBSD

mmc: Fix regression in 8a8166e5bcfb breaking Stratix 10 boot
ClosedPublic

Authored by jrtc27 on Sep 28 2021, 6:19 PM.
Tags
None
Referenced Files
F169777433: D32209.id95883.diff
Wed, Sep 2, 1:10 PM
F169703831: D32209.id95883.diff
Wed, Sep 2, 8:22 AM
F169564120: D32209.id.diff
Tue, Sep 1, 10:41 PM
Unknown Object (File)
Mon, Aug 31, 11:11 PM
Unknown Object (File)
Mon, Aug 31, 1:24 PM
Unknown Object (File)
Mon, Aug 31, 8:15 AM
Unknown Object (File)
Sun, Aug 30, 10:50 PM
Unknown Object (File)
Sat, Aug 29, 3:00 PM
Subscribers

Details

Summary

The refactoring in 8a8166e5bcfb introduced a functional change that
breaks booting on the Stratix 10, hanging when it should be attaching
da0. Previously OF_getencprop was called with a pointer to host->f_max,
so if it wasn't present then the existing value was left untouched, but
after that commit it will instead clobber the value with 0. The dwmmc
driver, as used on the Stratix 10, sets a default value before calling
mmc_fdt_parse and so was broken by this functional change. It appears
that aw_mmc also does the same thing, so was presumably also broken on
some boards.

Fixes: 8a8166e5bcfb ("mmc: switch mmc_helper to device_ api")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable