Page MenuHomeFreeBSD

arm64: Fix a logic bug in is_load_instr().
ClosedPublic

Authored by jhb on Sep 13 2021, 6:30 PM.
Tags
None
Referenced Files
F132224552: D31949.id95075.diff
Tue, Oct 14, 11:13 PM
Unknown Object (File)
Tue, Oct 14, 2:26 PM
Unknown Object (File)
Tue, Oct 14, 2:26 PM
Unknown Object (File)
Tue, Oct 14, 12:43 AM
Unknown Object (File)
Mon, Oct 13, 11:27 AM
Unknown Object (File)
Sat, Oct 4, 9:59 AM
Unknown Object (File)
Mon, Sep 29, 2:47 AM
Unknown Object (File)
Sun, Sep 28, 4:49 PM
Subscribers

Details

Summary

Logical and ('&&') was used to join two conditions instead of logical
or ('||') causing some store instructions to not be recognized.

Reported by: GCC 9 -Wparentheses

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 13 2021, 6:30 PM

I wonder if we need this. The store macro looks broken, they are only used in ddb to count instructions, and are defined as 0 on most architectures.

This revision is now accepted and ready to land.Sep 15 2021, 9:12 AM

I have no idea if this is needed or not TBH.

This revision was automatically updated to reflect the committed changes.