Page MenuHomeFreeBSD

arm64: Fix a logic bug in is_load_instr().
ClosedPublic

Authored by jhb on Mon, Sep 13, 6:30 PM.

Details

Summary

Logical and ('&&') was used to join two conditions instead of logical
or ('||') causing some store instructions to not be recognized.

Reported by: GCC 9 -Wparentheses

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Mon, Sep 13, 6:30 PM

I wonder if we need this. The store macro looks broken, they are only used in ddb to count instructions, and are defined as 0 on most architectures.

This revision is now accepted and ready to land.Wed, Sep 15, 9:12 AM

I have no idea if this is needed or not TBH.

This revision was automatically updated to reflect the committed changes.