Page MenuHomeFreeBSD

graphics/libpano13: Update to 2.9.20
ClosedPublic

Authored by diizzy on Mon, Sep 13, 5:58 AM.

Details

Summary

Some small changes compared to submitted patch:

PORTVERSION --> DISTVERSION
Add CMAKE_ARGS= -DCMAKE_DISABLE_FIND_PACKAGE_GnuTar:BOOL=True to reduce noise (only used for packaging)
Add STATIC option (library not provided in previous version and it's hardcoded in upstream's Makefile)
Sort OPTIONS_DEFINE
Disable build of unit tests / test suite (hardcoded) and confirmed broken by upstream for now
Ref: https://groups.google.com/g/hugin-ptx/c/leMFlRYImvQ
Minor cosmetic changes to Makefile for readability

Submitter has tested this update with port Hugin
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258354

Test Plan

Compile tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist)
Poudriere testport OK 11.4-RELEASE (amd64)
Poudriere testport OK 12.2-RELEASE (amd64)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

diizzy created this revision.

There's also an VuXML entry related to this release, I'll add that to a separate review

graphics/libpano13/Makefile
17

You can use CMAKE_ON=CMAKE_DISABLE_FIND_PACKAGE_GnuTar`

Use CMAKE_ON as suggested by lbartoletti
Add USES= pkgconfig to further reduce noise during build

graphics/libpano13/Makefile
17

Fixed, thanks

Upstream have fixed tests here https://sourceforge.net/p/panotools/libpano13/ci/fd9dd14043810725ec94b2c55a6e0159655501bd/ so I'll give it a go and backport these plus enable unit tests

Since patch doesn't like binary patches would it be acceptable to use bsdiff and bspatch instead?

There's no good way of pulling down the new test files from upstream and attaching binary diffs are a bit idea in git so leave it as it is until upstream releases a new version. This would be the final version that goes into tree

There's no good way of pulling down the new test files from upstream and attaching binary diffs are a bit idea in git so leave it as it is until upstream releases a new version. This would be the final version that goes into tree

Moin moin

let's not mix too much here -- the PR in concern is about a CVE. So I'd suggest to do two things

  1. update this review for purely the CVE that can go in ASAP :)
  2. do the cleanup/test-related stuff afterwards

mfg Tobias

fuz_fuz.su added a subscriber: fuz_fuz.su.

As already discussed, I have not asked for a STATIC option to be added not have I asked for the test suite to be disabled. In fact, I do not wish to maintain these changes. Please remove them as already discussed on IRC.

graphics/libpano13/Makefile
22

I have not asked for a STATIC option to be added and I do not want to maintain this extra option. Please remove it.

graphics/libpano13/files/patch-CMakeLists.txt
35

The test suite is only broken in this one release. With this change, I have to edit the patch for each subsequent release just to find out if the test suite no longer fails. I have neither asked for nor agreed to this change and I have already told you so. Please remove this change and do not disable the testsuite.

This revision now requires changes to proceed.Fri, Sep 17, 8:42 PM
This revision was not accepted when it landed; it landed in state Needs Revision.Mon, Sep 20, 6:09 AM
This revision was automatically updated to reflect the committed changes.