Page MenuHomeFreeBSD

libc/locale: Fix races between localeconv(3) and setlocale(3)
ClosedPublic

Authored by markj on Sep 10 2021, 2:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 14, 9:04 AM
Unknown Object (File)
Tue, Dec 24, 11:46 AM
Unknown Object (File)
Dec 14 2024, 6:54 AM
Unknown Object (File)
Nov 25 2024, 9:23 AM
Unknown Object (File)
Nov 24 2024, 1:13 PM
Unknown Object (File)
Nov 24 2024, 1:13 PM
Unknown Object (File)
Nov 23 2024, 9:51 AM
Unknown Object (File)
Nov 22 2024, 9:31 AM
Subscribers

Details

Summary

Each locale embeds a lazily initialized lconv which is populated by
localeconv(3) and localeconv_l(3). When setlocale(3) updates the global
locale, the lconv needs to be (lazily) reinitialized. To signal this,
we set flag variables in the locale structure. There are two problems:

- The flags are set before the locale is fully updated, so a concurrent
  localeconv() call can observe partially initialized locale data.
- No barriers ensure that localeconv() observes a fully initialized
  locale if a flag is set.

So, move the flag update appropriately, and use acq/rel barriers to
provide some synchronization.

Thanks to Henry Hu <henry.hu.sh@gmail.com> for providing a test case
demonstrating the race.

PR: 258360
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Sep 10 2021, 2:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 17 2021, 3:00 PM
This revision was automatically updated to reflect the committed changes.