Page MenuHomeFreeBSD

cmake: hoist cmake version to cmake.mk
Needs ReviewPublic

Authored by tcberner on Sep 9 2021, 7:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 29, 11:37 AM
Unknown Object (File)
Dec 20 2023, 2:37 AM
Unknown Object (File)
Nov 6 2023, 1:21 PM
Unknown Object (File)
Nov 5 2023, 12:59 AM
Unknown Object (File)
Nov 2 2023, 4:42 PM
Unknown Object (File)
Oct 5 2023, 12:15 PM
Unknown Object (File)
Oct 4 2023, 1:05 AM
Unknown Object (File)
Sep 30 2023, 12:57 AM
Subscribers

Details

Reviewers
arrowd
adridg
lbartoletti
Group Reviewers
portmgr
kde
Summary

The version of the cmake port has been scattered in four ports.
This change moves the version to a single point: cmake.mk, which now
exposes it as _CMAKE_VERSION. It also got a new _internal argument
to mask away all the other magic it does for devel/cmake to be able
to include it.

  • devel/cmake, devel/cmake-gui, devel/cmake-doc:

use DISTVERISON=${_CMAKE_VERSION}
let cmake.mk handle MASTER_SITES

  • devel/kms-cmake-utils:

use ${_CMAKE_VERSION_R} as PLIST_SUB

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 41452
Build 38341: arc lint + arc unit

Event Timeline

rene added inline comments.
Mk/Uses/cmake.mk
62
171

Why not use DISTVERSION twice here instead of DISTVERSION and PORTVERSION ?

The internal variable _CMAKE_VERSION should probably be mentioned somewhere in cmake.mk -- it's not a tunable variable, but it is used by ports (e.g. kms-cmake-utils) and should therefore have documentation.

Mk/Uses/cmake.mk
20
# _internal             Not to be used by any other ports than the ones created from the 
#                       release-tarball of cmake (i.e. devel/cmake).
62
# Only devel/cmake should set argument '_internal'. If it is not set, depend on devel/cmake
# and introduce the knobs for a build-with-CMake port.
171

That seems to have been copied from the devel/cmake/Makefile and has been that way for some time; you are right that it seems weirdly inconsistent.