Page MenuHomeFreeBSD

socket: Avoid clearing SS_ISCONNECTING if soconnect() fails
ClosedPublic

Authored by markj on Aug 26 2021, 9:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 12:30 AM
Unknown Object (File)
Dec 22 2023, 2:17 PM
Unknown Object (File)
Dec 20 2023, 2:56 AM
Unknown Object (File)
Dec 14 2023, 8:34 PM
Unknown Object (File)
Dec 14 2023, 10:57 AM
Unknown Object (File)
Dec 12 2023, 1:16 PM
Unknown Object (File)
Oct 10 2023, 4:23 PM
Unknown Object (File)
Oct 3 2023, 11:47 AM
Subscribers

Details

Summary

This behaviour appears to date from the 4.4 BSD import. It has two
problems:

  1. The update to so_state is racy, and this can cause problems in the socket connection state machine. In particular it means that the check in solisten_proto_check() fails to catch a connecting socket.
  2. Suppose two threads race to call connect(2) on a socket, and one succeeds while the other fails. Then the failing thread may incorrectly clear SS_ISCONNECTING, confusing the state machine.

Simply remove the update. I don't believe it's necessary: pru_connect
implementations which call soisconnecting() only do so after all failure
modes have been handled. For instance, tcp_connect() and tcp6_connect()
will never return an error after calling soisconnected(). However, we
cannot correctly assert that SS_ISCONNECTED is _not_ set after an error
from soconnect().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable