Page MenuHomeFreeBSD

Minimalistic patch to fulfil the TCP LRO contract
ClosedPublic

Authored by tuexen on Aug 25 2021, 5:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 26 2024, 5:09 PM
Unknown Object (File)
Sep 30 2024, 6:03 AM
Unknown Object (File)
Sep 23 2024, 6:45 AM
Unknown Object (File)
Sep 22 2024, 11:51 PM
Unknown Object (File)
Sep 22 2024, 8:10 PM
Unknown Object (File)
Sep 22 2024, 7:40 PM
Unknown Object (File)
Sep 22 2024, 3:04 PM
Unknown Object (File)
Sep 18 2024, 8:19 PM
Subscribers
None

Details

Summary

When calling certain functions of the TCP LRO code, the caller has to enter the network epoch before. This patch ensures that. However, performance wise it might be far from optimal and should be improved by someone knowing the driver.

This fixes the issue reported in PR254695.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen created this revision.

I would do it in hn_nvs_handle_rxbuf(). Eg, take the epoch outside the for() loop, so it is held for all rx pkt reception.

Address comment from gallatin@.

I would do it in hn_nvs_handle_rxbuf(). Eg, take the epoch outside the for() loop, so it is held for all rx pkt reception.

I agree... Done.

This revision is now accepted and ready to land.Aug 25 2021, 8:26 PM