Page MenuHomeFreeBSD

Minimalistic patch to fulfil the TCP LRO contract
ClosedPublic

Authored by tuexen on Aug 25 2021, 5:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 2:33 AM
Unknown Object (File)
Dec 13 2023, 8:33 AM
Unknown Object (File)
Mar 22 2023, 6:09 PM
Unknown Object (File)
Mar 5 2023, 7:40 AM
Unknown Object (File)
Jan 7 2023, 5:21 PM
Unknown Object (File)
Dec 22 2022, 12:25 AM
Subscribers
None

Details

Summary

When calling certain functions of the TCP LRO code, the caller has to enter the network epoch before. This patch ensures that. However, performance wise it might be far from optimal and should be improved by someone knowing the driver.

This fixes the issue reported in PR254695.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen created this revision.

I would do it in hn_nvs_handle_rxbuf(). Eg, take the epoch outside the for() loop, so it is held for all rx pkt reception.

Address comment from gallatin@.

I would do it in hn_nvs_handle_rxbuf(). Eg, take the epoch outside the for() loop, so it is held for all rx pkt reception.

I agree... Done.

This revision is now accepted and ready to land.Aug 25 2021, 8:26 PM