Page MenuHomeFreeBSD

e1000: Style fixes for shared code.
ClosedPublic

Authored by erj on Jul 23 2015, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 2:14 AM
Unknown Object (File)
Sep 11 2024, 4:41 PM
Unknown Object (File)
Sep 10 2024, 5:55 AM
Unknown Object (File)
Sep 6 2024, 11:08 AM
Unknown Object (File)
Aug 22 2024, 11:56 PM
Unknown Object (File)
Aug 22 2024, 11:56 PM
Unknown Object (File)
Aug 22 2024, 11:23 PM
Unknown Object (File)
Jul 26 2024, 2:09 PM
Subscribers

Details

Reviewers
gnn
sbruno
Summary
  • Spaces replaced with tabs
  • Braces
  • TRUE/true and FALSE/false replacement
  • !! replacing () ? true : false

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

erj retitled this revision from to e1000: Whitespace fixes for shared code..
erj updated this object.
erj edited the test plan for this revision. (Show Details)
erj retitled this revision from e1000: Whitespace fixes for shared code. to e1000: Style fixes for shared code..Jul 23 2015, 12:23 AM

Just to ease my sanity, we should just double check that older gcc in base knows what to do with !!()

Does this build trivially for fbsd8?

In D3159#63327, @sbruno wrote:

Just to ease my sanity, we should just double check that older gcc in base knows what to do with !!()

Does this build trivially for fbsd8?

It totally does. The semantics of this haven't changed since before K&R published its first edition.
And there's code in the tree that does this.

This revision is now accepted and ready to land.Jul 23 2015, 6:39 PM