Differential D31585

witness: remove ifnet_rw
ClosedPublic
Actions

Authored by kp on Aug 17 2021, 12:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 21, 7:30 AM

	Unknown Object (File)
	Mon, Oct 21, 6:25 AM

	Unknown Object (File)
	Fri, Oct 11, 9:19 AM

	Unknown Object (File)
	Tue, Oct 1, 6:21 PM

	Unknown Object (File)
	Sep 13 2024, 4:25 AM

	Unknown Object (File)
	Sep 11 2024, 1:29 PM

	Unknown Object (File)
	Sep 8 2024, 6:41 AM

	Unknown Object (File)
	Sep 6 2024, 12:19 AM

View All 40 Files

Subscribers

dheerajk_netapp.com

Details

Reviewers

Summary

This lock no longer exists. It was removed in
a60100fdfc106f8966fa572fa72e82b0813c623b

Pointed out by: Dheeraj Kandula <dheerajk@netapp.com>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41098
Build 37987: arc lint + arc unit

Event Timeline

kp created this revision.Aug 17 2021, 12:57 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 17 2021, 12:57 PM

kp requested review of this revision.Aug 17 2021, 12:57 PM

Harbormaster completed remote builds in B41098: Diff 93825.Aug 17 2021, 12:57 PM

kp mentioned this in D27278: if: Remove ifnet_rwlock.Aug 17 2021, 12:58 PM

mjg accepted this revision.Aug 17 2021, 1:22 PM

This revision is now accepted and ready to land.Aug 17 2021, 1:22 PM

The ifnet_sxlock lock is still present. Isn't that grabbed during the multicast code path? If so, shouldn't that be added to the lock order?

In D31585#712027, @dheerajk_netapp.com wrote:

The ifnet_sxlock lock is still present. Isn't that grabbed during the multicast code path? If so, shouldn't that be added to the lock order?

Possibly, but it's not present right now either.
The entries here are hints of the expected locking order, for witness to check, so if it's not complaining now (and I think it's not) the extra hint isn't needed.

kp mentioned this in rG07edc89c393c: witness: remove ifnet_rw.Aug 18 2021, 8:52 AM

kp closed this revision.Aug 19 2021, 8:37 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

2 lines

Diff 93825

sys/kern/subr_witness.c

Loading...