Page MenuHomeFreeBSD

witness: remove ifnet_rw
ClosedPublic

Authored by kp on Aug 17 2021, 12:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 21 2024, 7:30 AM
Unknown Object (File)
Oct 21 2024, 6:25 AM
Unknown Object (File)
Oct 11 2024, 9:19 AM
Unknown Object (File)
Oct 1 2024, 6:21 PM
Unknown Object (File)
Sep 13 2024, 4:25 AM
Unknown Object (File)
Sep 11 2024, 1:29 PM
Unknown Object (File)
Sep 8 2024, 6:41 AM
Unknown Object (File)
Sep 6 2024, 12:19 AM

Details

Reviewers
mjg
Summary

This lock no longer exists. It was removed in
a60100fdfc106f8966fa572fa72e82b0813c623b

Pointed out by: Dheeraj Kandula <dheerajk@netapp.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41098
Build 37987: arc lint + arc unit

Event Timeline

kp requested review of this revision.Aug 17 2021, 12:57 PM
This revision is now accepted and ready to land.Aug 17 2021, 1:22 PM

The ifnet_sxlock lock is still present. Isn't that grabbed during the multicast code path? If so, shouldn't that be added to the lock order?

The ifnet_sxlock lock is still present. Isn't that grabbed during the multicast code path? If so, shouldn't that be added to the lock order?

Possibly, but it's not present right now either.
The entries here are hints of the expected locking order, for witness to check, so if it's not complaining now (and I think it's not) the extra hint isn't needed.