Page MenuHomeFreeBSD

dheerajk_netapp.com (Dheeraj Kandula)
User

Projects

User Details

User Since
Apr 30 2021, 1:33 PM (60 w, 6 d)

Recent Activity

Apr 6 2022

dheerajk_netapp.com added a comment to D22154: Delayed context for SIOCADDMULTI.

If you look at:

void
_epoch_enter_preempt(epoch_t epoch, epoch_tracker_t et EPOCH_FILE_LINE)
{
...
        THREAD_NO_SLEEPING();

You find that in_epoch() implies THREAD_CAN_SLEEP() == 0 .

--HPS

Apr 6 2022, 3:45 PM
dheerajk_netapp.com added a comment to D22154: Delayed context for SIOCADDMULTI.

I think a delmultitask would be appropriate to avoid races on the if_ioctl handler, adding and removing multicast addresses.

Regarding in_epoch() in non-sleepable context, this is not an issue. Entering and exiting epoch should not block or sleep.

Apr 6 2022, 3:43 PM
dheerajk_netapp.com added a comment to D22154: Delayed context for SIOCADDMULTI.

Shouldn't the THREAD_CAN_SLEEP also check for in_epoch() test? I have come across threads that have the td_no_sleeping set to 0 and are inside an epoch section.

Apr 6 2022, 2:28 PM
dheerajk_netapp.com added a comment to D22154: Delayed context for SIOCADDMULTI.

Shouldn't there be a similar fix for if_delmulti? This change only addresses if_addmulti. If the change is not required for if_delmulti, can you add the justification for why it is not required.

Apr 6 2022, 2:26 PM

Jan 27 2022

dheerajk_netapp.com added a comment to rG206bed574a98: MFC r338947:.

Shouldn't the state->flags be set before invoking print_instruction from inside print_address, i.e. before 2076?

Jan 27 2022, 5:59 PM

Nov 11 2021

dheerajk_netapp.com added a comment to rG774d7183a0ec: MFC r331668:.

Why is the function show_prerequisites removed?

Nov 11 2021, 12:42 AM

Aug 17 2021

dheerajk_netapp.com added a comment to D31585: witness: remove ifnet_rw.

The ifnet_sxlock lock is still present. Isn't that grabbed during the multicast code path? If so, shouldn't that be added to the lock order?

Aug 17 2021, 2:24 PM

Aug 16 2021

dheerajk_netapp.com added a comment to D27278: if: Remove ifnet_rwlock.

How about the lock order in subr_witness.c for IPv4 and Ipv6 multicast. Is it still required in the lock order?

Aug 16 2021, 6:05 PM

Jun 11 2021

dheerajk_netapp.com added a reviewer for D30741: Restore VNET before returning in error paths in vlan_setmulti.: gnn.
Jun 11 2021, 6:43 PM
dheerajk_netapp.com requested review of D30741: Restore VNET before returning in error paths in vlan_setmulti..
Jun 11 2021, 6:42 PM