Page MenuHomeFreeBSD
Differential D3153

Document the fact that tunables may be set in device.hints.
ClosedPublic
Actions

Authored by brooks on Jul 22 2015, 4:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 8, 7:56 PM
Unknown Object (File)
Sun, Sep 8, 3:53 PM
Unknown Object (File)
Thu, Sep 5, 9:36 PM
Unknown Object (File)
Thu, Sep 5, 9:34 PM
Unknown Object (File)
Thu, Sep 5, 4:13 PM
Unknown Object (File)
Wed, Sep 4, 3:47 PM
Unknown Object (File)
Fri, Aug 30, 12:47 PM
Unknown Object (File)
Mon, Aug 19, 3:03 AM
View All 87 Files
Subscribers
imp

Details

Reviewers
wblock
Group Reviewers
manpages
Commits
rS285817: Document the fact that tunables can be set in device.hints.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks updated this revision to Diff 7181.Jul 22 2015, 4:38 PM
brooks retitled this revision from to Document the fact that tunables may be set in device.hints..
brooks updated this object.
brooks edited the test plan for this revision. (Show Details)
brooks added a reviewer: wblock.
Herald added a reviewer: manpages. · View Herald TranscriptJul 22 2015, 4:38 PM
Herald added a subscriber: imp. · View Herald Transcript
wblock added inline comments.Jul 22 2015, 5:12 PM
share/man/man5/device.hints.5
45 ↗(On Diff #7181)

How about:

but may also be used to set kernel tunable values.

155 ↗(On Diff #7181)

"may" implies permission, "can" is better, but here it can just say

Setting a tunable variable:

(I plan on a followup commit to make the other examples similarly concise.)

brooks updated this revision to Diff 7226.Jul 23 2015, 4:11 PM
brooks edited edge metadata.

Address feedback from wblock.

wblock accepted this revision.Jul 23 2015, 4:59 PM
wblock edited edge metadata.

Works for me. Please check with igor -R device.hints.5 | less -RS (textproc/igor) and mandoc -Tlint device.hints.5 before commit. Thanks!

This revision is now accepted and ready to land.Jul 23 2015, 4:59 PM
brooks added a comment.Jul 23 2015, 5:26 PM

Hmm, igor complains about a missing SYNOPSIS this appears to be correct for section 5 manpages.

Closed by commit rS285817: Document the fact that tunables can be set in device.hints. (authored by brooks). · Explain WhyJul 23 2015, 5:27 PM
This revision was automatically updated to reflect the committed changes.
wblock added a comment.Jul 23 2015, 6:20 PM
In D3153#63258, @brooks wrote:

Hmm, igor complains about a missing SYNOPSIS this appears to be correct for section 5 manpages.

Yes, it's a false positive. Although I can't say for a fact that it should always ignore a missing synopsis in section 5. There are some section 8 man pages that also (correctly) do not have a synopsis, like gptboot(8). Unless maybe we expand the definition of synopsis as used in man pages... Anyway, thanks for working on this!

Revision Contents
Changeset List

PathSize
head/
share/
man/
man5/
18 lines

Diff 7229

View Options

head/share/man/man5/device.hints.5

Loading...