Page MenuHomeFreeBSD

Fix lockstat:::thread-spin dtrace probe with LOCK_PROFILING
ClosedPublic

Authored by vangyzen on Aug 2 2021, 6:59 PM.
Tags
None
Referenced Files
F153263659: D31384.id.diff
Mon, Apr 20, 3:24 AM
Unknown Object (File)
Thu, Apr 16, 1:25 AM
Unknown Object (File)
Tue, Apr 14, 6:16 AM
Unknown Object (File)
Fri, Apr 10, 12:01 PM
Unknown Object (File)
Mon, Apr 6, 10:04 PM
Unknown Object (File)
Sun, Apr 5, 2:34 PM
Unknown Object (File)
Sat, Apr 4, 6:36 AM
Unknown Object (File)
Sat, Apr 4, 3:36 AM
Subscribers

Details

Summary

The spinning start time is missing from the calculation due to a
misplaced #endif. Return the #endif where it's supposed to be.

Submitted by: Alexander Alexeev <aalexeev@isilon.com>
MFC after: 1 week
Sponsored by: Dell EMC Isilon

Test Plan

From the submitter:

Without

dtrace -n 'lockstat:::thread-spin { trace((int64_t)arg1); exit(0); }'
dtrace: description 'lockstat:::thread-spin ' matched 1 probe
CPU     ID                    FUNCTION:NAME
 18  79691                 none:thread-spin     3878139600799

With

dtrace -n 'lockstat:::thread-spin { trace((uint64_t)arg1); exit(0); }'

dtrace: description 'lockstat:::thread-spin ' matched 1 probe
CPU     ID                    FUNCTION:NAME
  3  79618                 none:thread-spin               838

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable