devclass_alloc_unit: move "at" hint test to after device-in-use test
ClosedPublic
Actions

Authored by adam_fenn.io on Aug 2 2021, 12:46 PM.

Details

Reviewers

Commits

rG8ca384eb1d42: devclass_alloc_unit: move "at" hint test to after device-in-use test

Summary

Only perform this expensive operation when the unit number is a
potential candidate (i.e. not already in use), thereby reducing device
scan time on systems with many devices, unit numbers, and drivers.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
X-NetApp-PR: #61

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40803
Build 37692: arc lint + arc unit

Event Timeline

adam_fenn.io created this revision.Aug 2 2021, 12:46 PM

adam_fenn.io held this revision as a draft.

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptAug 2 2021, 12:46 PM

Harbormaster completed remote builds in B40803: Diff 93105.Aug 2 2021, 12:46 PM

adam_fenn.io published this revision for review.Aug 2 2021, 12:49 PM

This looks good. Need someone to commit it?

This revision is now accepted and ready to land.Aug 2 2021, 2:30 PM

In D31381#707302, @imp wrote:

This looks good. Need someone to commit it?

I'll grab it

Closed by commit rG8ca384eb1d42: devclass_alloc_unit: move "at" hint test to after device-in-use test (authored by adam_fenn.io, committed by kevans). · Explain WhyAug 2 2021, 4:30 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG8ca384eb1d42: devclass_alloc_unit: move "at" hint test to after device-in-use test.

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_bus.c

8 lines

Diff 93105

View Options

devclass_alloc_unit: move "at" hint test to after device-in-use testClosedPublicActions