arm64: Print CPU features slightly earlier
ClosedPublic
Actions

Authored by markj on Jul 20 2021, 4:07 PM.

Details

Reviewers

andrew
manu

Commits

rGfa46a46a8249: arm64: Print CPU features slightly earlier

Summary

In particular, print them before we release APs. Otherwise they tend to
get mixed with other kernel messages.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 20 2021, 4:07 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 20 2021, 4:07 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

markj requested review of this revision.Jul 20 2021, 4:07 PM

Harbormaster completed remote builds in B40563: Diff 92504.Jul 20 2021, 4:07 PM

emaste added inline comments.Jul 20 2021, 4:45 PM

sys/arm64/arm64/identcpu.c
1319–1320	IMO it's worth a comment when we have these `- 1` or `+ 1` cases explaining why.

Add a comment.

Harbormaster completed remote builds in B40567: Diff 92509.Jul 20 2021, 6:49 PM

andrew accepted this revision.Jul 21 2021, 8:46 AM

This revision is now accepted and ready to land.Jul 21 2021, 8:46 AM

manu accepted this revision.Jul 21 2021, 8:47 AM

Closed by commit rGfa46a46a8249: arm64: Print CPU features slightly earlier (authored by markj). · Explain WhyJul 21 2021, 1:03 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGfa46a46a8249: arm64: Print CPU features slightly earlier.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

identcpu.c

3 lines

Diff 92574

View Options

sys/arm64/arm64/identcpu.c

arm64: Print CPU features slightly earlierClosedPublicActions