Page MenuHomeFreeBSD

kern: mountroot: avoid fd leak in .md parsing
ClosedPublic

Authored by kevans on Jul 20 2021, 10:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 9 2024, 4:31 PM
Unknown Object (File)
Dec 20 2023, 4:11 AM
Unknown Object (File)
Dec 12 2023, 2:34 PM
Unknown Object (File)
Nov 22 2023, 3:37 PM
Unknown Object (File)
Nov 22 2023, 3:36 PM
Unknown Object (File)
Nov 22 2023, 2:55 PM
Unknown Object (File)
Nov 20 2023, 10:15 AM
Unknown Object (File)
Nov 12 2023, 1:21 PM
Subscribers

Details

Summary

parse_dir_md() opens /dev/mdctl but only closes the resulting fd on
success, not upon failure of the ioctl or when we exceed the md unit
max.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
X-NetApp-PR: #62

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/kern/vfs_mountroot.c
641

I do not believe there is much use in preserving close' error.

This revision is now accepted and ready to land.Jul 20 2021, 2:28 PM
This revision was automatically updated to reflect the committed changes.
kevans marked an inline comment as done.