Page MenuHomeFreeBSD
Differential D31229

kern: mountroot: avoid fd leak in .md parsing
ClosedPublic
Actions

Authored by kevans on Jul 20 2021, 10:32 AM.
Tags
None
Referenced Files
F139068882: D31229.diff
Sun, Dec 7, 8:35 AM
Unknown Object (File)
Mon, Dec 1, 3:40 PM
Unknown Object (File)
Fri, Nov 28, 1:19 PM
Unknown Object (File)
Sun, Nov 23, 11:52 PM
Unknown Object (File)
Mon, Nov 17, 2:36 AM
Unknown Object (File)
Fri, Nov 14, 9:44 PM
Unknown Object (File)
Sat, Nov 8, 5:30 AM
Unknown Object (File)
Nov 6 2025, 9:21 PM
View All 98 Files
Subscribers
imp

Details

Reviewers
trasz
kib
Commits
rG23ecfa9d5bc4: kern: mountroot: avoid fd leak in .md parsing
Summary

parse_dir_md() opens /dev/mdctl but only closes the resulting fd on
success, not upon failure of the ioctl or when we exceed the md unit
max.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.
X-NetApp-PR: #62

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Jul 20 2021, 10:32 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 20 2021, 10:32 AM
kevans requested review of this revision.Jul 20 2021, 10:32 AM
Harbormaster completed remote builds in B40548: Diff 92480.Jul 20 2021, 10:32 AM
kib accepted this revision.Jul 20 2021, 2:28 PM
kib added inline comments.
sys/kern/vfs_mountroot.c
641

I do not believe there is much use in preserving close' error.

This revision is now accepted and ready to land.Jul 20 2021, 2:28 PM
Closed by commit rG23ecfa9d5bc4: kern: mountroot: avoid fd leak in .md parsing (authored by kevans). · Explain WhyJul 21 2021, 3:19 PM
This revision was automatically updated to reflect the committed changes.
kevans marked an inline comment as done.
kevans added a commit: rG23ecfa9d5bc4: kern: mountroot: avoid fd leak in .md parsing.

Revision Contents
Changeset List

PathSize
sys/
kern/
5 lines

Diff 92577

View Options

sys/kern/vfs_mountroot.c

Loading...