Details
Details
- Reviewers
ygy carlavilla - Group Reviewers
docs portmgr - Commits
- R9:92f5023b666d: Contributing to ports: encourage using git-format-patch(1) and seeking help
Diff Detail
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| documentation/content/en/articles/contributing/_index.adoc | ||
|---|---|---|
| 376 | s/doest't/don't/ | |
| documentation/content/en/articles/contributing/_index.adoc | ||
|---|---|---|
| 376 | ||
| documentation/content/en/articles/contributing/_index.adoc | ||
|---|---|---|
| 376 | Also, maybe be more specific than "a certain time"? Perhaps something like "4-6 weeks" or whatever matches actual practice? | |
| documentation/content/en/articles/contributing/_index.adoc | ||
|---|---|---|
| 376 | I'd like to keep the current statement, originally I wanted to put "2 weeks as the maintainer timeout" but I think it is somehow too long. Maybe adding "if it exceeds 2 weeks as the maintainer timeout, you definitely need to ask for attention." ? | |
| documentation/content/en/articles/contributing/_index.adoc | ||
|---|---|---|
| 376 | That would work for me, sez the totally-not-a-ports-expert reviewer. | |
Comment Actions
A minor rephrasing suggestion, other than that it looks good to me!
| documentation/content/en/articles/contributing/_index.adoc | ||
|---|---|---|
| 376 | ||
| documentation/content/en/articles/contributing/_index.adoc | ||
|---|---|---|
| 375–376 | instead of adding a new phrase, I would just extend the initial phrase: It may take minutes, or it may take one or two weeks - so please be patient. If it takes any longer, please seek for help on mailing lists (ports@freebsd.org), irc: #bsdports on efnet or #freebsd on libera for example. | |