Page MenuHomeFreeBSD

Contributing to ports: encourage using git-format-patch(1) and seeking help
AcceptedPublic

Authored by lwhsu on Fri, Jul 16, 5:27 PM.

Details

Reviewers
ygy
Group Reviewers
docs
portmgr

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 40506
Build 37395: arc lint + arc unit

Event Timeline

lwhsu requested review of this revision.Fri, Jul 16, 5:27 PM
lwhsu created this revision.
jlduran_gmail.com added inline comments.
documentation/content/en/articles/contributing/_index.adoc
375

s/doest't/don't/

ygy added inline comments.
documentation/content/en/articles/contributing/_index.adoc
375
pauamma_gundo.com added inline comments.
documentation/content/en/articles/contributing/_index.adoc
376

Also, maybe be more specific than "a certain time"? Perhaps something like "4-6 weeks" or whatever matches actual practice?

documentation/content/en/articles/contributing/_index.adoc
376

I'd like to keep the current statement, originally I wanted to put "2 weeks as the maintainer timeout" but I think it is somehow too long. Maybe adding "if it exceeds 2 weeks as the maintainer timeout, you definitely need to ask for attention." ?

documentation/content/en/articles/contributing/_index.adoc
376

That would work for me, sez the totally-not-a-ports-expert reviewer.

A minor rephrasing suggestion, other than that it looks good to me!

documentation/content/en/articles/contributing/_index.adoc
376
This revision is now accepted and ready to land.Mon, Jul 19, 11:37 PM
bapt added inline comments.
documentation/content/en/articles/contributing/_index.adoc
375

instead of adding a new phrase, I would just extend the initial phrase:

It may take minutes, or it may take one or two weeks - so please be patient. If it takes any longer, please seek for help on mailing lists (ports@freebsd.org), irc: #bsdports on efnet or #freebsd on libera for example.