Page MenuHomeFreeBSD
Differential D31145

nfsd: Fix some issues found by mandoc
ClosedPublic
Actions

Authored by gbe on Jul 11 2021, 12:42 PM.
Tags
None
Referenced Files
F81617542: D31145.diff
Fri, Apr 19, 1:20 AM
Unknown Object (File)
Thu, Mar 28, 5:14 PM
Unknown Object (File)
Fri, Mar 22, 9:32 PM
Unknown Object (File)
Fri, Mar 22, 9:32 PM
Unknown Object (File)
Fri, Mar 22, 9:31 PM
Unknown Object (File)
Mar 8 2024, 6:24 AM
Unknown Object (File)
Jan 4 2024, 10:10 PM
Unknown Object (File)
Jan 4 2024, 10:10 PM
View All 31 Files
Subscribers
bcr
imp

Details

Reviewers
bcr
Group Reviewers
manpages
Commits
rG2800c163f083: nfsd: Fix some issues found by mandoc
rG4c87085d3521: nfsd: Fix some issues found by mandoc
Summary
  • consider using OS macro: Fx

MFC after: 1 week

Test Plan

'mandoc -Tlint' checks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40441
Build 37330: arc lint + arc unit

Event Timeline

gbe created this revision.Jul 11 2021, 12:42 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 11 2021, 12:42 PM
gbe requested review of this revision.Jul 11 2021, 12:42 PM
Harbormaster completed remote builds in B40441: Diff 92074.Jul 11 2021, 12:42 PM
bcr accepted this revision.Jul 11 2021, 1:13 PM
bcr added a subscriber: bcr.

Separate issue found about the use of you.
The actual change looks fine to me. Thanks!

usr.sbin/nfsd/pnfs.4
215

Maybe we can avoid the use of "you" here as well by writing "set the sysctl ..." or "must be set".
Perhaps in a separate commit.

This revision is now accepted and ready to land.Jul 11 2021, 1:13 PM
Closed by commit rG4c87085d3521: nfsd: Fix some issues found by mandoc (authored by gbe). · Explain WhyJul 12 2021, 4:33 AM
This revision was automatically updated to reflect the committed changes.
gbe added a commit: rG4c87085d3521: nfsd: Fix some issues found by mandoc.
gbe added a commit: rG2800c163f083: nfsd: Fix some issues found by mandoc.Jul 19 2021, 6:16 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
nfsd/
4 lines
51 lines
41 lines

Diff 92074

View Options

usr.sbin/nfsd/nfsv4.4

Loading...
View Options

usr.sbin/nfsd/pnfs.4

Loading...
View Options

usr.sbin/nfsd/pnfsserver.4

Loading...