Page MenuHomeFreeBSD
Differential D30979

LinuxKPI: add sign_extend32()
ClosedPublic
Actions

Authored by bz on Jul 1 2021, 1:16 PM.

Details

Reviewers
imp
emaste
hselasky
Group Reviewers
linuxkpi
Commits
R10:ea4dea83944a: LinuxKPI: add sign_extend32()
Summary

Add sign_extend32() needed by rtw88.

MFC after: 10 days

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bz created this revision.Jul 1 2021, 1:16 PM
Herald added a subscriber: emaste. · View Herald TranscriptJul 1 2021, 1:16 PM
bz requested review of this revision.Jul 1 2021, 1:16 PM
Harbormaster completed remote builds in B40211: Diff 91613.Jul 1 2021, 1:16 PM
imp accepted this revision.Jul 1 2021, 3:25 PM
This revision is now accepted and ready to land.Jul 1 2021, 3:25 PM
emaste accepted this revision.Jul 1 2021, 3:26 PM
hselasky added a subscriber: hselasky.Jul 1 2021, 3:31 PM
hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/bitops.h
415

should index be uint8_t aswell?

emaste added inline comments.Jul 1 2021, 4:25 PM
sys/compat/linuxkpi/common/include/linux/bitops.h
415

This matches the function signature from Linux

bz added inline comments.Jul 1 2021, 11:48 PM
sys/compat/linuxkpi/common/include/linux/bitops.h
415

@emaste "this" being "int" or "uint8_t"? The 64bit version above only had a "int" and I went by that,

hselasky accepted this revision.Jul 2 2021, 8:03 AM
Closed by commit R10:ea4dea83944a: LinuxKPI: add sign_extend32() (authored by bz). · Explain WhyJul 27 2021, 3:08 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: R10:ea4dea83944a: LinuxKPI: add sign_extend32().

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
8 lines

Diff 92799

View Options

sys/compat/linuxkpi/common/include/linux/bitops.h

Loading...