Page MenuHomeFreeBSD
Differential D30953

ofw_pci: Fix probing
ClosedPublic
Actions

Authored by kd on Jun 30 2021, 10:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 15, 8:06 PM
Unknown Object (File)
Wed, Apr 15, 1:12 PM
Unknown Object (File)
Wed, Apr 15, 5:47 AM
Unknown Object (File)
Tue, Apr 14, 7:47 PM
Unknown Object (File)
Tue, Apr 14, 12:43 PM
Unknown Object (File)
Tue, Apr 14, 2:29 AM
Unknown Object (File)
Wed, Apr 8, 9:13 AM
Unknown Object (File)
Wed, Apr 1, 4:38 PM
View All Files
Subscribers
None

Details

Reviewers
mw
andrew
mmel
nwhitehorn
Commits
rG94287656264f: ofw_pci: fix probing for non-DT cases
Summary

phandle_t is a uint32_t type, <= 0 comparison doesn't work with it as intended.
This caused the ofw_pci code to attach to PCI bus on ACPI based systems.
Since 3eae4e106ac7 ofw subsystem can only return -1 for invalid nodes.
Use that.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kd requested review of this revision.Jun 30 2021, 10:01 AM
kd created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2021, 6:36 PM
Closed by commit rG94287656264f: ofw_pci: fix probing for non-DT cases (authored by kd, committed by mw). · Explain Why
This revision was automatically updated to reflect the committed changes.
mw added a commit: rG94287656264f: ofw_pci: fix probing for non-DT cases.

Revision Contents
Changeset List

PathSize
sys/
dev/
ofw/
2 lines

Diff 91628

View Options

sys/dev/ofw/ofw_pci.c

Loading...