[UPSTREAM] vis(3) avoid out-of-bounds stack buffer reads
ClosedPublic
Actions

Authored by arichardson on Jun 15 2021, 12:27 PM.

Details

Reviewers

brooks
bdrewery
jhb

Commits

rGc89f104c12e1: vis(3): avoid out-of-bounds stack buffer reads
rG1a2f06d0f290: vis(3): avoid out-of-bounds stack buffer reads

Summary

I found this while running kdump(1) on a CheriBSD system due to a
capability length violation when printing the /etc/libmap.conf read()
system call: it crashed immediately after printing the first line.

Found by: CHERI

Test Plan

No longer crashes with this change

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Jun 15 2021, 12:27 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 15 2021, 12:27 PM

arichardson requested review of this revision.Jun 15 2021, 12:27 PM

Harbormaster completed remote builds in B39916: Diff 90913.Jun 15 2021, 12:27 PM

arichardson mentioned this in D30772: kdump: use VIS_NOLOCALE when printing output.Jun 15 2021, 12:31 PM

jhb accepted this revision.Jun 15 2021, 4:33 PM

This revision is now accepted and ready to land.Jun 15 2021, 4:33 PM

Closed by commit rG1a2f06d0f290: vis(3): avoid out-of-bounds stack buffer reads (authored by arichardson). · Explain WhyJun 16 2021, 4:21 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG1a2f06d0f290: vis(3): avoid out-of-bounds stack buffer reads.

arichardson mentioned this in rG1a3a57d74590: kdump: use VIS_NOLOCALE when printing output.

arichardson added a commit: rGc89f104c12e1: vis(3): avoid out-of-bounds stack buffer reads.Jul 5 2021, 9:48 AM

arichardson mentioned this in rG5694f4af7916: kdump: use VIS_NOLOCALE when printing output.

Revision Contents
Changeset List

Path

Size

contrib/

libc-vis/

vis.c

3 lines

Diff 90965

View Options

[UPSTREAM] vis(3) avoid out-of-bounds stack buffer readsClosedPublicActions