bsnmp: Fix incorrect use of libpfctl
ClosedPublic
Actions

Authored by kp on Jun 15 2021, 12:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 9, 3:10 AM

	Unknown Object (File)
	Sun, Sep 6, 10:34 PM

	Unknown Object (File)
	Sat, Aug 22, 3:12 AM

	Unknown Object (File)
	Wed, Aug 12, 7:41 PM

	Unknown Object (File)
	Wed, Aug 12, 7:28 PM

	Unknown Object (File)
	Aug 10 2026, 8:51 AM

	Unknown Object (File)
	Aug 9 2026, 4:22 PM

	Unknown Object (File)
	Aug 8 2026, 2:25 AM

View All Files

Subscribers

donner

imp

Details

Reviewers

donner

Group Reviewers

network
pfsense

Summary

When we introduced libpfctl in bnsmpd this was done incorrectly, and a
GETRULE call was replaced by pfctl_add_rule().
Change it to pfctl_get_rule().

MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39915
Build 36804: arc lint + arc unit

Event Timeline

kp created this revision.Jun 15 2021, 12:09 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 15 2021, 12:09 PM

kp requested review of this revision.Jun 15 2021, 12:09 PM

Harbormaster completed remote builds in B39915: Diff 90912.Jun 15 2021, 12:10 PM

How could this happen?

This revision is now accepted and ready to land.Jun 15 2021, 1:20 PM

In D30770#691853, @donner wrote:

How could this happen?

Probably I got distracted doing these modifications, and didn't spot it when I committed.
We don't currently have any tests for the pf snmp module. Those would hopefully have caught it. Instead we wound up catching it during Netgate testing.

Committed as 67cef6d411cef0c3dfcf768ff890b4f97cf513b6

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsnmpd/

modules/

snmp_pf/

pf_snmp.c

4 lines

Diff 90912

View Options

usr.sbin/bsnmpd/modules/snmp_pf/pf_snmp.c

bsnmp: Fix incorrect use of libpfctlClosedPublicActions