tip: Cast via intptr_t not long when casting between pointer and int
ClosedPublic
Actions

Authored by jrtc27 on Jun 8 2021, 2:57 PM.

Details

Reviewers

brooks
imp
kib

Commits

rGde295884c4ef: tip: Cast via intptr_t not long when casting between pointer and int

Summary

Whilst all FreeBSD architectures have the same representation for
intptr_t and long (even if the former is int on ILP32 architectures),
this is more general and correct, and on CHERI they are not the same so
warnings are generated by default for integer-to-pointer casts that
aren't via (u)intptr_t.

Obtained from: CheriBSD

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 requested review of this revision.Jun 8 2021, 2:57 PM

jrtc27 created this revision.

Harbormaster completed remote builds in B39802: Diff 90586.Jun 8 2021, 2:57 PM

jrtc27 added a child revision: D30697: tip: Fix pointer-vs-integer confusion.Jun 8 2021, 3:07 PM

jrtc27 added inline comments.

usr.bin/tip/tip/tip.h
157–161	The whitespace here is actually dodgy (number has a tab, but boolean and character have spaces after them). I didn't notice when writing this patch, only the next one, but can update that when committing this if approved.